I will refrain from discussing in too much detail.
But I am going through the code base of a client and I am finding that there are several different styles in the code. Some are down right contradictory.
Some of this code is OLD, like circa 2002 or something.
Most of the code I am working with on a daily basis was developed in like 2009 and was done by a small group of programmers with little turnover.
It is interesting to see how a code base looks after years, and years of maintenance being done to it after all of the original developers are gone.
I think much like the repair on a buildings foundation, you begin to see structural ‘steel’ as it were being put in around areas where you need to reinforce a failing part of the structure.
Much like Kevin, I am fighting the urge to recommend a full rebuild. Because, the work that I am doing, is more like changing all the locks on all the doors in the building. Just because as I am installing the locks, I see that all the hinges need to be replaced because they are not matching or some seemingly installed backwards (yet the doors still open).
I managed to get beyond some of the issues that had me scratching my head for a few minutes as I try to setup a simple test driver for the code I am writing. I even fixed a few benign NOTICE errors that were related to an outdated syntax reference as it was driving me nuts. (Funny thing is, in my day-to-day coding, I am the cause of these, resulting in Kevin fixing them. So I guess this is Karma.)